From 34c00f398b6b841c7f6bbac0e90352fe70d57b79 Mon Sep 17 00:00:00 2001
From: Sebastian Zagrodzki <sebek@zagrodzki.net>
Date: Wed, 22 Feb 2017 01:35:13 +0100
Subject: [PATCH] - more tests, for "out" endpoint.

---
 usb/endpoint.go           |  8 ++---
 usb/endpoint_info_test.go | 16 +++++++++
 usb/endpoint_test.go      | 71 ++++++++++++++++++++++++++++++++-------
 3 files changed, 76 insertions(+), 19 deletions(-)

diff --git a/usb/endpoint.go b/usb/endpoint.go
index 0f5f9e5..044f70b 100644
--- a/usb/endpoint.go
+++ b/usb/endpoint.go
@@ -17,7 +17,6 @@ package usb
 
 import (
 	"fmt"
-	"log"
 	"time"
 )
 
@@ -74,7 +73,6 @@ func (e *endpoint) transfer(buf []byte, timeout time.Duration) (int, error) {
 		return 0, nil
 	}
 
-	tt := e.TransferType()
 	t, err := e.newUSBTransfer(buf, timeout)
 	if err != nil {
 		return 0, err
@@ -82,16 +80,14 @@ func (e *endpoint) transfer(buf []byte, timeout time.Duration) (int, error) {
 	defer t.free()
 
 	if err := t.submit(); err != nil {
-		log.Printf("bulk: %s failed to submit: %s", tt, err)
 		return 0, err
 	}
 
 	n, err := t.wait()
 	if err != nil {
-		log.Printf("bulk: %s failed: %s", tt, err)
-		return 0, err
+		return n, err
 	}
-	return n, err
+	return n, nil
 }
 
 func newEndpoint(d *Device) *endpoint {
diff --git a/usb/endpoint_info_test.go b/usb/endpoint_info_test.go
index b212f95..d19a323 100644
--- a/usb/endpoint_info_test.go
+++ b/usb/endpoint_info_test.go
@@ -28,3 +28,19 @@ var testBulkInSetup = InterfaceSetup{
 	IfClass:   uint8(CLASS_VENDOR_SPEC),
 	Endpoints: []EndpointInfo{testBulkInEP},
 }
+
+// OUT iso endpoint
+var testIsoOutEP = EndpointInfo{
+	Address:       0x06,
+	Attributes:    uint8(TRANSFER_TYPE_ISOCHRONOUS),
+	MaxPacketSize: 3<<11 + 1024,
+	MaxIsoPacket:  3 * 1024,
+	PollInterval:  1,
+}
+
+var testIsoOutSetup = InterfaceSetup{
+	Number:    0,
+	Alternate: 0,
+	IfClass:   uint8(CLASS_VENDOR_SPEC),
+	Endpoints: []EndpointInfo{testIsoOutEP},
+}
diff --git a/usb/endpoint_test.go b/usb/endpoint_test.go
index 990c250..459ae22 100644
--- a/usb/endpoint_test.go
+++ b/usb/endpoint_test.go
@@ -15,6 +15,8 @@
 package usb
 
 import (
+	"errors"
+	"reflect"
 	"testing"
 	"time"
 )
@@ -30,23 +32,66 @@ func (t *fakeTransfer) wait() (int, error) { return t.ret, t.err }
 func (*fakeTransfer) free() error          { return nil }
 
 func TestEndpoint(t *testing.T) {
-	ep := endpoint{
+	for _, epSetup := range []struct {
+		method string
+		InterfaceSetup
+		EndpointInfo
+	}{
+		{"Read", testBulkInSetup, testBulkInEP},
+		{"Write", testIsoOutSetup, testIsoOutEP},
+	} {
+		t.Run(epSetup.method, func(t *testing.T) {
+			for _, tc := range []struct {
+				buf     []byte
+				ret     int
+				err     error
+				want    int
+				wantErr bool
+			}{
+				{buf: nil, ret: 10, want: 0},
+				{buf: make([]byte, 128), ret: 60, want: 60},
+				{buf: make([]byte, 128), ret: 10, err: errors.New("some error"), want: 10, wantErr: true},
+			} {
+				ep := &endpoint{
+					InterfaceSetup: epSetup.InterfaceSetup,
+					EndpointInfo:   epSetup.EndpointInfo,
+					newUSBTransfer: func(buf []byte, timeout time.Duration) (transferIntf, error) {
+						return &fakeTransfer{buf: buf, ret: tc.ret, err: tc.err}, nil
+					},
+				}
+				op, ok := reflect.TypeOf(ep).MethodByName(epSetup.method)
+				if !ok {
+					t.Fatalf("method %s not found in endpoint", epSetup.method)
+				}
+				opv := op.Func.Interface().(func(*endpoint, []byte) (int, error))
+				got, err := opv(ep, tc.buf)
+				if (err != nil) != tc.wantErr {
+					t.Errorf("bulkInEP.Read(): got err: %v, err != nil is %v, want %v", err, err != nil, tc.wantErr)
+					continue
+				}
+				if got != tc.want {
+					t.Errorf("bulkInEP.Read(): got %d bytes, want %d", got, tc.want)
+				}
+			}
+		})
+	}
+}
+
+func TestEndpointWrongDirection(t *testing.T) {
+	ep := &endpoint{
 		InterfaceSetup: testBulkInSetup,
 		EndpointInfo:   testBulkInEP,
-		newUSBTransfer: func(buf []byte, timeout time.Duration) (transferIntf, error) {
-			return &fakeTransfer{buf}, nil
-		},
 	}
-	b := make([]byte, 128)
-	got, err := ep.Read(b)
-	if err != nil {
-		t.Fatalf("bulkInEP.Read(): got error: %v, want nil", err)
-	}
-	if want := len(b)/2 + 1; got != want {
-		t.Errorf("bulkInEP.Read(): got %d bytes, want half of the buffer length: %d", got, want)
-	}
-	_, err := ep.Write(b)
+	_, err := ep.Write([]byte{1, 2, 3})
 	if err == nil {
 		t.Error("bulkInEP.Write(): got nil error, want non-nil")
 	}
+	ep = &endpoint{
+		InterfaceSetup: testIsoOutSetup,
+		EndpointInfo:   testIsoOutEP,
+	}
+	_, err = ep.Read(make([]byte, 64))
+	if err == nil {
+		t.Error("isoOutEP.Read(): got nil error, want non-nil")
+	}
 }