Use a new behavior of newFakeLibusb.

Add a benchmark for subslicing.

usb/device_test.go

@@ -20,9 +20,8 @@ import (
 )
 
 func TestOpenEndpoint(t *testing.T) {
-	origLib := libusb
+	_, done := newFakeLibusb()
-	defer func() { libusb = origLib }()
+	defer done()
-	libusb = newFakeLibusb()
 
 	c := NewContext()
 	defer c.Close()

usb/endpoint_test.go

@@ -20,7 +20,9 @@ import (
 )
 
 func TestEndpoint(t *testing.T) {
-	defer func(i libusbIntf) { libusb = i }(libusb)
+	lib, done := newFakeLibusb()
+	defer done()
+
 	for _, epData := range []struct {
 		ei   EndpointInfo
 		intf InterfaceSetting
@@ -83,9 +85,6 @@ func TestEndpoint(t *testing.T) {
 				wantErr: true,
 			},
 		} {
-			lib := newFakeLibusb()
-			libusb = lib
-
 			ep := newEndpoint(nil, epData.intf, epData.ei)
 			go func() {
 				fakeT := lib.waitForSubmitted()
@@ -150,8 +149,8 @@ func TestEndpointInfo(t *testing.T) {
 func TestEndpointIn(t *testing.T) {
 	defer func(i libusbIntf) { libusb = i }(libusb)
 
-	lib := newFakeLibusb()
+	lib, done := newFakeLibusb()
-	libusb = lib
+	defer done()
 
 	ctx := NewContext()
 	defer ctx.Close()
@@ -187,8 +186,8 @@ func TestEndpointIn(t *testing.T) {
 func TestEndpointOut(t *testing.T) {
 	defer func(i libusbIntf) { libusb = i }(libusb)
 
-	lib := newFakeLibusb()
+	lib, done := newFakeLibusb()
-	libusb = lib
+	defer done()
 
 	ctx := NewContext()
 	defer ctx.Close()

usb/transfer_test.go

@@ -20,8 +20,8 @@ import (
 )
 
 func TestNewTransfer(t *testing.T) {
-	defer func(i libusbIntf) { libusb = i }(libusb)
+	_, done := newFakeLibusb()
-	libusb = newFakeLibusb()
+	defer done()
 
 	for _, tc := range []struct {
 		desc        string
@@ -62,6 +62,7 @@ func TestNewTransfer(t *testing.T) {
 		if err != nil {
 			t.Fatalf("newUSBTransfer(): %v", err)
 		}
+		defer xfer.free()
 		if got, want := len(xfer.buf), tc.wantLength; got != want {
 			t.Errorf("xfer.buf: got %d bytes, want %d", got, want)
 		}
@@ -69,10 +70,8 @@ func TestNewTransfer(t *testing.T) {
 }
 
 func TestTransferProtocol(t *testing.T) {
-	defer func(i libusbIntf) { libusb = i }(libusb)
+	f, done := newFakeLibusb()
-
+	defer done()
-	f := newFakeLibusb()
-	libusb = f
 
 	xfers := make([]*usbTransfer, 2)
 	var err error
@@ -140,3 +139,20 @@ func TestTransferProtocol(t *testing.T) {
 		x.free()
 	}
 }
+
+func BenchmarkSubSlice(b *testing.B) {
+	x := make([]byte, 512)
+	start, len := 50, 50
+	b.Run("start:start+len", func(b *testing.B) {
+		for i := 0; i < b.N; i++ {
+			y := x
+			y = y[start : start+len]
+		}
+	})
+	b.Run("[start:][:len]", func(b *testing.B) {
+		for i := 0; i < b.N; i++ {
+			y := x
+			y = y[start:][:len]
+		}
+	})
+}

usb/usb_test.go

@@ -18,9 +18,8 @@ package usb
 import "testing"
 
 func TestListDevices(t *testing.T) {
-	orig := libusb
+	_, done := newFakeLibusb()
-	defer func() { libusb = orig }()
+	defer done()
-	libusb = newFakeLibusb()
 
 	c := NewContext()
 	defer c.Close()
@@ -55,9 +54,8 @@ func TestListDevices(t *testing.T) {
 }
 
 func TestOpenDeviceWithVidPid(t *testing.T) {
-	orig := libusb
+	_, done := newFakeLibusb()
-	defer func() { libusb = orig }()
+	defer done()
-	libusb = newFakeLibusb()
 
 	for _, d := range []struct {
 		vid, pid ID